Repository navigation
Apply the org-wide scaffold docs from ph-ee-start-here - #2
Closed
GiulioRinalduzzi wants to merge 1 commit into
Closed
GiulioRinalduzzi wants to merge 1 commit into
GiulioRinalduzzi wants to merge 1 commit into
Conversation
David asked for these four files to be the same across every new repo. Taken byte-identical from ph-ee-start-here, so the content hash matches the source and drift can be spotted later. That is why contributing.md is lowercase: it is the name used upstream. CODE_OF_CONDUCT.md replaced LICENSE replaced contributing.md replaces CONTRIBUTING.md security.md new, was missing The CONTRIBUTING.md being replaced is the generic Mifos template: it points contributors at Jira project MXWAR and MXWAR-<ID> branch names, and still carries two unfilled placeholders. The upstream version is the Payment Hub one, pointing at PHEE and #payment-hub. No formatter exclusion is needed in this repo.
Contributor
Author
|
Folded into #1 instead, so this repo gets one PR rather than two. Same commit, byte-identical files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the org-wide scaffold docs from ph-ee-start-here
David asked for these four files to be the same across every new repo. Taken
byte-identical from ph-ee-start-here, so the content hash matches the source and
drift can be spotted later. That is why contributing.md is lowercase: it is the
name used upstream.
CODE_OF_CONDUCT.md replaced
LICENSE replaced
contributing.md replaces CONTRIBUTING.md
security.md new, was missing
The CONTRIBUTING.md being replaced is the generic Mifos template: it points
contributors at Jira project MXWAR and MXWAR- branch names, and still carries
two unfilled placeholders. The upstream version is the Payment Hub one, pointing
at PHEE and #payment-hub.
No formatter exclusion is needed in this repo.
One thing worth a second look before merging: the only difference in LICENSE is
line 360. This repo has https://mozilla.org/MPL/2.0/ and the version in
ph-ee-start-here has http://. So applying it as-is swaps a secure link for a
plain one. It looks like the upstream copy is simply the older one. Happy to drop
LICENSE from this PR and keep the three others if you prefer.