fix : Top Bar Titles updation #2827
Conversation
feature/about/src/commonMain/kotlin/org/mifos/mobile/feature/about/ui/PrivacyPolicyScreen.kt
Outdated
Show resolved
Hide resolved
|
@revanthkumarJ Add a screenshot what you have refactored. |
niyajali
left a comment
There was a problem hiding this comment.
@revanthkumarJ We're creating TopAppBar for each screen instead of using the core MifosTopAppBar component which does the same. consider use that one
.../kotlin/org/mifos/mobile/feature/guarantor/screens/guarantorDetails/GuarantorDetailTopBar.kt
Outdated
Show resolved
Hide resolved
|
@niyajali @Nagarjuna0033 can you review it once and approve this if no changes are required |
niyajali
left a comment
There was a problem hiding this comment.
Create these overload and use all over the project based on its requirement instead of creating TopAppBar for each screen
core/ui/src/commonMain/kotlin/org/mifos/mobile/core/ui/component/UserProfileTopBar.kt
Outdated
Show resolved
Hide resolved
core/ui/src/commonMain/kotlin/org/mifos/mobile/core/ui/component/UserProfileTopBar.kt
Outdated
Show resolved
Hide resolved
feature/about/src/commonMain/kotlin/org/mifos/mobile/feature/about/ui/AboutUsScreen.kt
Outdated
Show resolved
Hide resolved
|
@niyajali removed all externally defined topBars and used only MifosTopAppBar and done necessary changes so that they work for all top Bars can you review it once |
niyajali
left a comment
There was a problem hiding this comment.
Have you verified that the TopAppBar maintains a consistent appearance and behavior across all screens in the application? Could you ensure it follows the same design guidelines (e.g., elevation, title style, navigation icon, and actions) on every screen where it's used?
@niyajali yes i have verified it in all screens the functionality is working fine and it followed same styles like fontSize medium and navigationIcon (backArrow in all screen and menu in home etc.) |


Fixes - Jira-#231
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.