Skip to content

fix : Top Bar Titles updation #2827

Merged
niyajali merged 10 commits intoopenMF:kmp-implfrom
revanthkumarJ:Enhancements
Mar 27, 2025
Merged

fix : Top Bar Titles updation #2827
niyajali merged 10 commits intoopenMF:kmp-implfrom
revanthkumarJ:Enhancements

Conversation

@revanthkumarJ
Copy link
Contributor

Fixes - Jira-#231

Didn't create a Jira ticket, click here to create new.

Please Add Screenshots If there are any UI changes.

Before After

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the static analysis check ./gradlew check or ci-prepush.sh to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@Nagarjuna0033
Copy link
Contributor

@revanthkumarJ Add a screenshot what you have refactored.

@revanthkumarJ revanthkumarJ changed the title Top Bar Titles updation and removing dependencies block Top Bar Titles updation Mar 24, 2025
@revanthkumarJ
Copy link
Contributor Author

@Nagarjuna0033

In Privacy policy screen

Before After
image image

And in other screens topBar i didn't changed ui .changed fontSizes only

Before:
uses for some topbars 24.sp for some titleLarge and some titleMedium

Now:
changed all to follow a similar one i.e titleMedium

Copy link
Collaborator

@niyajali niyajali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@revanthkumarJ We're creating TopAppBar for each screen instead of using the core MifosTopAppBar component which does the same. consider use that one

@revanthkumarJ revanthkumarJ changed the title Top Bar Titles updation fix : Top Bar Titles updation Mar 24, 2025
@revanthkumarJ
Copy link
Contributor Author

@niyajali @Nagarjuna0033 can you review it once and approve this if no changes are required

Copy link
Collaborator

@niyajali niyajali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create these overload and use all over the project based on its requirement instead of creating TopAppBar for each screen

@revanthkumarJ
Copy link
Contributor Author

@niyajali removed all externally defined topBars and used only MifosTopAppBar and done necessary changes so that they work for all top Bars

can you review it once

@revanthkumarJ revanthkumarJ requested a review from niyajali March 27, 2025 09:21
Copy link
Collaborator

@niyajali niyajali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you verified that the TopAppBar maintains a consistent appearance and behavior across all screens in the application? Could you ensure it follows the same design guidelines (e.g., elevation, title style, navigation icon, and actions) on every screen where it's used?

@revanthkumarJ
Copy link
Contributor Author

Have you verified that the TopAppBar maintains a consistent appearance and behavior across all screens in the application? Could you ensure it follows the same design guidelines (e.g., elevation, title style, navigation icon, and actions) on every screen where it's used?

@niyajali yes i have verified it in all screens the functionality is working fine and it followed same styles like fontSize medium and navigationIcon (backArrow in all screen and menu in home etc.)

@niyajali niyajali merged commit 1645f62 into openMF:kmp-impl Mar 27, 2025
6 of 7 checks passed
Nagarjuna0033 pushed a commit to Nagarjuna0033/mifos-mobile that referenced this pull request May 12, 2025
therajanmaurya pushed a commit that referenced this pull request May 13, 2025
Samriddhi743 pushed a commit to Samriddhi743/mifos-mobile that referenced this pull request Oct 3, 2025
Naman-kr404 pushed a commit to Naman-kr404/mifos-mobile that referenced this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants