fix : UpdateServerConfig (navigation,ui)#2414
Merged
niyajali merged 17 commits intoopenMF:kmp-implfrom Jun 27, 2025
Merged
Conversation
# Conflicts: # cmp-navigation/src/commonMain/kotlin/cmp/navigation/navigation/FeatureNavHost.kt # cmp-navigation/src/commonMain/kotlin/cmp/navigation/navigation/RootNavGraph.kt # feature/groups/src/commonMain/kotlin/com/mifos/feature/groups/groupList/GroupsListScreen.kt
biplab1
approved these changes
Jun 26, 2025
Contributor
biplab1
left a comment
biplab1
left a comment
There was a problem hiding this comment.
The changes look good to me. This can be merged.
biplab1
reviewed
Jun 26, 2025
feature/settings/src/commonMain/composeResources/values/strings.xml
Outdated
Show resolved
Hide resolved
...gs/src/commonMain/kotlin/com/mifos/feature/settings/updateServer/UpdateServerConfigScreen.kt
Outdated
Show resolved
Hide resolved
Contributor
Author
WhatsApp.Video.2025-06-26.at.10.25.33.PM.mp4 |
Contributor
|
The snackbar countdown message shows two 'in's. Could you please correct it? |
biplab1
approved these changes
Jun 26, 2025
Contributor
Author
|
Video showcasing screen rotations WhatsApp.Video.2025-06-26.at.10.54.06.PM.mp4 |
Nagarjuna0033
approved these changes
Jun 26, 2025
itsPronay
reviewed
Jun 26, 2025
...e/settings/src/commonMain/kotlin/com/mifos/feature/settings/navigation/SettingsNavigation.kt
Outdated
Show resolved
Hide resolved
niyajali
approved these changes
Jun 27, 2025
itsPronay
pushed a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
itsPronay
pushed a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#476
what achieved in this pr:
added logic to navigate to serverConfig from login
Updated ServerConfig ui to align with dev branch
WhatsApp.Video.2025-06-26.at.6.16.48.PM.mp4