fix : Loan Module clean up (Api , Viewmodel )#2411
Merged
niyajali merged 9 commits intoopenMF:kmp-implfrom Jun 25, 2025
Merged
Conversation
# Conflicts: # feature/client/src/commonMain/kotlin/com/mifos/feature/client/clientDetails/ClientDetailsScreen.kt # feature/client/src/commonMain/kotlin/com/mifos/feature/client/clientDetails/ClientDetailsViewModel.kt
Nagarjuna0033
approved these changes
Jun 25, 2025
biplab1
reviewed
Jun 25, 2025
core/model/src/commonMain/kotlin/com/mifos/core/model/objects/account/loan/RepaymentSchedule.kt
Outdated
Show resolved
Hide resolved
core/model/src/commonMain/kotlin/com/mifos/core/model/objects/account/loan/RepaymentSchedule.kt
Outdated
Show resolved
Hide resolved
feature/loan/src/commonMain/kotlin/com/mifos/feature/loan/loanRepayment/LoanRepaymentScreen.kt
Outdated
Show resolved
Hide resolved
...an/src/commonMain/kotlin/com/mifos/feature/loan/loanApproval/LoanAccountApprovalViewModel.kt
Outdated
Show resolved
Hide resolved
biplab1
approved these changes
Jun 25, 2025
Aditya3815
approved these changes
Jun 25, 2025
revanthkumarJ
changed the title
niyajali
approved these changes
Jun 25, 2025
itsPronay
pushed a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
Co-authored-by: Nagarjuna <nagarjunabanda4@gmail.com>
itsPronay
pushed a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
Co-authored-by: Nagarjuna <nagarjunabanda4@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#456
Api fixes
Removing commented code
Enhancing Viewmodel
In this pr checked all loan screens available from loan Summary screen and others are checked and changed at some places to make api calls run