fix image rendering in client and payment screen#2410
Merged
niyajali merged 7 commits intoopenMF:kmp-implfrom Jun 25, 2025
Merged
fix image rendering in client and payment screen#2410niyajali merged 7 commits intoopenMF:kmp-implfrom
niyajali merged 7 commits intoopenMF:kmp-implfrom
Conversation
revanthkumarJ
approved these changes
Jun 24, 2025
biplab1
reviewed
Jun 24, 2025
...in/kotlin/com/mifos/feature/individualCollectionSheet/paymentDetails/PaymentDetailsScreen.kt
Outdated
Show resolved
Hide resolved
biplab1
approved these changes
Jun 24, 2025
Contributor
|
@niyajali Nagarjuna is following a very different approach compared to the one used in the kmp-project-template. It looks good to me. Please do a final review, and if everything checks out, kindly go ahead and merge it. |
biplab1
reviewed
Jun 24, 2025
...lient/src/commonMain/kotlin/com/mifos/feature/client/clientDetails/ClientDetailsViewModel.kt
Outdated
Show resolved
Hide resolved
niyajali
requested changes
Jun 24, 2025
...kotlin/com/mifos/feature/individualCollectionSheet/paymentDetails/PaymentDetailsViewModel.kt
Outdated
Show resolved
Hide resolved
...in/kotlin/com/mifos/feature/individualCollectionSheet/paymentDetails/PaymentDetailsScreen.kt
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@revanthkumarJ after making changes let me know |
Contributor
|
Updated Image after Image is successfully loading
|
revanthkumarJ
approved these changes
Jun 24, 2025
niyajali
approved these changes
Jun 25, 2025
itsPronay
pushed a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
Co-authored-by: revanthkumarJ <jrevanth101@gmail.com>
itsPronay
pushed a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
Co-authored-by: revanthkumarJ <jrevanth101@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#455
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.