-
Notifications
You must be signed in to change notification settings - Fork 29
Chore: Migrate Tubolinks to Turbo #2953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2953 +/- ##
==========================================
- Coverage 69.60% 69.57% -0.03%
==========================================
Files 214 214
Lines 6820 6820
==========================================
- Hits 4747 4745 -2
- Misses 2073 2075 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a19087f
to
da9610e
Compare
@@ -13,7 +13,7 @@ $(document).on('turbolinks:load', function(event) { | |||
CodeOceanEditorRequestForComments | |||
); | |||
|
|||
if ($('#editor').isPresent() && CodeOceanEditor && event.originalEvent.data.url.includes("/implement")) { | |||
if ($('#editor').isPresent() && CodeOceanEditor && event.originalEvent.detail.url.includes("/implement")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
detail is the data popery that is used in CustomeEvent. The original Turbolinks used none standard custom events to support IE. With Turbo.js the standard for events is used.
app/javascript/tooltip.js
Outdated
@@ -0,0 +1,25 @@ | |||
const tooltipMap = new WeakMap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When moving Turbo.js into the application JS managed by webpack, some timing issues with the Bootstrap JQuery plugin accrued. The plugin was not loaded the first time turbo:load
fires.
The pervious version had two event listeners for the tooltips. This version is capable of collecting garbage and operating on a global scale.
Trubolinks has been replaced by Turbo. The Turbolinks library has been achieved. Resolves #2952
704ecdd
to
d656bd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are still some order dependent issues. I am considering what to do. |
Trubolinks has been replaced by Turbo. The Turbolinks library has been achieved.
Resolves #2952