Skip to content

Refactor newSentryTransaction to use improved API #2322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2024

Conversation

MrSerth
Copy link
Member

@MrSerth MrSerth commented May 27, 2024

This change is based on a suggestion by Sentry staff. It requires SDK version > 8.4.0, which is not yet released.

getsentry/sentry-javascript#12116 (comment)
getsentry/sentry-javascript#12138

@MrSerth MrSerth added enhancement javascript Pull requests that update Javascript code labels May 27, 2024
@MrSerth MrSerth requested review from jgraichen and Dome-GER May 27, 2024 08:38
@MrSerth MrSerth self-assigned this May 27, 2024
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.40%. Comparing base (e20ee45) to head (4e0cdb2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2322   +/-   ##
=======================================
  Coverage   69.40%   69.40%           
=======================================
  Files         199      199           
  Lines        6278     6278           
=======================================
  Hits         4357     4357           
  Misses       1921     1921           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrSerth MrSerth force-pushed the sentry_start_new_trace branch from 3e73c65 to 4e0cdb2 Compare May 28, 2024 06:31
@MrSerth MrSerth marked this pull request as ready for review May 28, 2024 06:31
@MrSerth MrSerth merged commit a99d860 into master May 28, 2024
9 checks passed
@MrSerth MrSerth deleted the sentry_start_new_trace branch May 28, 2024 13:08
Copy link
Member

@jgraichen jgraichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants