Add ProFormA validity checks and disable exporting not invalid #2054
+110
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkoehn
force-pushed
the
1888-align-proforma-validations-with-task-model
branch
from
fac8f4e to
097234e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2054 +/- ##
==========================================
+ Coverage 94.74% 94.75% +0.01%
==========================================
Files 133 133
Lines 3404 3412 +8
==========================================
+ Hits 3225 3233 +8
Misses 179 179 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arkirchner
reviewed
Jul 7, 2025
| @@ -45,6 +45,7 @@ def show | |||
| @files = @task.files | |||
| @tests = @task.tests | |||
| @model_solutions = @task.model_solutions | |||
| @proforma_valid = [nil, *ProformaXML::SCHEMA_VERSIONS].index_with {|v| @task.proforma_valid?(schema_version: v) } | |||
There was a problem hiding this comment.
It wasn't easy for me to figure this out. The nil case is the default case? It will be one of the versions listed in ProformaXML::SCHEMA_VERSIONS (the default version). The rest of the versions are used to enable the downloads for the specific versions?
I think this hash is a bit difficult to understand. Maybe we can create a new object like ProformaTaskValidation with the task as an input. This object to then do the validation you added to the model and integrate the check for each version. 🤔
kkoehn
force-pushed
the
1888-align-proforma-validations-with-task-model
branch
from
097234e to
29ff76d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds rudimentary ProFormA validation. In the show view exporting gets disabled when the export is not possible. For that the export service is called (twice) whenever the show view gets rendered. I'm not sure about the performance impact of that.