Add functionality to deselect radio buttons for usage_by_lms #1882
+31
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkoehn
force-pushed
the
1109-usage-by-lms-cannot-be-unset-through-ui
branch
from
afe3718 to
7b25902
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1882 +/- ##
=======================================
Coverage 94.74% 94.74%
=======================================
Files 133 133
Lines 3404 3405 +1
=======================================
+ Hits 3225 3226 +1
Misses 179 179 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kkoehn
force-pushed
the
1109-usage-by-lms-cannot-be-unset-through-ui
branch
from
7b25902 to
08609e0
Compare
arkirchner
reviewed
Jul 7, 2025
kkoehn
force-pushed
the
1109-usage-by-lms-cannot-be-unset-through-ui
branch
3 times, most recently
from
2fd61a8 to
4f5aa04
Compare
arkirchner
reviewed
Jul 8, 2025
| @@ -29,7 +29,5 @@ initializeVisibilityWarning = -> | |||
| warning_message.removeClass('d-none') | |||
| $('#task_access_level_public').on 'change', -> | |||
| warning_message.addClass('d-none') | |||
|
|
|||
There was a problem hiding this comment.
NITS: Can you leave the empty lines in?
arkirchner
approved these changes
Jul 8, 2025
kkoehn
force-pushed
the
1109-usage-by-lms-cannot-be-unset-through-ui
branch
2 times, most recently
from
61ad48a to
27b868f
Compare
kkoehn
force-pushed
the
1109-usage-by-lms-cannot-be-unset-through-ui
branch
from
27b868f to
996ccb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1109