remove custom bad_bins from expected and eigdecomp #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

sergpolly merged 3 commits into master from clean-bad-bins

Mar 14, 2022

Member

sergpolly commented Mar 6, 2022

addressing #331

sergpolly added 2 commits

March 6, 2022 00:03


          remove bad_bins from expected, misc. cleanups

2e74604


          remove bad bins from eigdecomp, recommend cooler blacklisting

sergpolly changed the title ~~[WIP] remove bad_bins from expected, misc. cleanups~~ remove custom bad_bins from expected and eigdecomp

Member Author

sergpolly commented Mar 6, 2022

removed "exotic" option to provide custom bad_bins to several functions in expected and eigdecomp.
although useful (e.g. ignore translocations) - it was rarely used, purely documented, and not tested
same can be achieved by manually modifying clr.bins()["weight"] using h5py, and similarly one could blacklist needed regions during cooler balance
misc. cleanups in expected and eigdecomp: value -> to_numpy, f-strings, etc

gfudenberg reviewed

View reviewed changes

cooltools/api/expected.py Outdated Show resolved Hide resolved

gfudenberg reviewed

View reviewed changes

cooltools/api/expected.py Outdated Show resolved Hide resolved

gfudenberg reviewed

View reviewed changes

cooltools/api/expected.py Show resolved Hide resolved

gfudenberg reviewed

View reviewed changes

cooltools/api/expected.py Outdated Show resolved Hide resolved

gfudenberg reviewed

View reviewed changes

cooltools/api/expected.py Outdated Show resolved Hide resolved

gfudenberg reviewed

View reviewed changes

cooltools/api/expected.py Outdated Show resolved Hide resolved

gfudenberg reviewed

View reviewed changes

cooltools/api/expected.py Outdated Show resolved Hide resolved

gfudenberg reviewed

View reviewed changes

cooltools/api/expected.py Outdated Show resolved Hide resolved

gfudenberg reviewed

View reviewed changes

cooltools/api/expected.py Show resolved Hide resolved

gfudenberg approved these changes

View reviewed changes


          update docstrings

b9b8aac

sergpolly merged commit 45a56df into master

sergpolly deleted the clean-bad-bins branch

March 14, 2022 17:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet