-
Notifications
You must be signed in to change notification settings - Fork 126
Conversation
Quote from open-webrtc-toolkit/owt-client-android#49 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HuaChunbo, @taste1981, could you please take a look at this PR. Make sure it fixes license issues.
test/p2ptest/package.json
Outdated
"socketio": "^1.0.0" | ||
}, | ||
"scripts": { | ||
"postinstall": "cd js && wget https://raw.githubusercontent.com/kriskowal/q/master/q.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wget
is not available on Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test will download q.js , how can i download this script both on windows and linux with one command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
test/p2ptest/start.py
Outdated
for browser in args.browsers: | ||
run(browser) | ||
|
||
os.remove(os.path.join(HOME_PATH, 'js/q.js')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script is supposed to be run only once?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
f.write(res_data.read()) | ||
|
||
|
||
if __name__ == '__main__': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
test/p2ptest/fetchq.py
Outdated
except: | ||
import urllib.request as u | ||
|
||
URL = "https://raw.githubusercontent.com/kriskowal/q/master/q.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A suggestion is to use a stable version instead of master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i try other q.js but only mster q.js is work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which version did you try?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Updates #52. |
test/p2ptest/fetchq.py
Outdated
except: | ||
import urllib.request as u | ||
|
||
URL = "https://raw.githubusercontent.com/kriskowal/q/no-console/q.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why no-console branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no-console branch is work ,and the last update is 11, 2014
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update master
No description provided.