Skip to content
This repository was archived by the owner on Oct 25, 2024. It is now read-only.

Remove qq.js , and modify some files #55

Merged
merged 1 commit into from
Dec 27, 2018
Merged

Remove qq.js , and modify some files #55

merged 1 commit into from
Dec 27, 2018

Conversation

zhangyihui1
Copy link
Contributor

No description provided.

@jianjunz
Copy link
Collaborator

Please do not file a new PR identical to an older one. You should update the code in the same PR.

Quote from open-webrtc-toolkit/owt-client-android#49

Copy link
Collaborator

@jianjunz jianjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HuaChunbo, @taste1981, could you please take a look at this PR. Make sure it fixes license issues.

"socketio": "^1.0.0"
},
"scripts": {
"postinstall": "cd js && wget https://raw.githubusercontent.com/kriskowal/q/master/q.js"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wget is not available on Windows.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test will download q.js , how can i download this script both on windows and linux with one command?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

for browser in args.browsers:
run(browser)

os.remove(os.path.join(HOME_PATH, 'js/q.js'))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script is supposed to be run only once?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

f.write(res_data.read())


if __name__ == '__main__':
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

except:
import urllib.request as u

URL = "https://raw.githubusercontent.com/kriskowal/q/master/q.js"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion is to use a stable version instead of master.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i try other q.js but only mster q.js is work

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which version did you try?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jianjunz
Copy link
Collaborator

Updates #52.

except:
import urllib.request as u

URL = "https://raw.githubusercontent.com/kriskowal/q/no-console/q.js"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why no-console branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-console branch is work ,and the last update is 11, 2014

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jianjunz jianjunz merged commit 4ac8ce5 into open-webrtc-toolkit:master Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants