This repository has been archived by the owner on Oct 25, 2024. It is now read-only.
Don't set remote description when a setLocalDescription is not resolved. #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please resolve conflicts before we can review this. |
Rebased. |
When the impolite side receives offer after `setLocalDescription`, before it's resolved, it sets both local description and remote description. Its signaling state changes from stable to have-local-offer, to stable, to have-remote-offer. It doesn't comply with the behavior of impolite side described in perfect negotiation, which is ignoring the remote description. Test: P2P case WebRTC collision should be resolved.
taste1981
approved these changes
Apr 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the impolite side receives offer after
setLocalDescription, before it'sresolved, it sets both local description and remote description. Its
signaling state changes from stable to have-local-offer, to stable, to
have-remote-offer. It doesn't comply with the behavior of impolite side
described in perfect negotiation, which is ignoring the remote
description.
Test: P2P case WebRTC collision should be resolved.
Fix #484.