Poc query balance #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlc
reviewed
May 22, 2024
poc/runtime/src/xcq.rs
Outdated
| // variant 0 means free balance | ||
| // variant 1 means reserved balance | ||
| // variant 2 means free+reserved | ||
| let mut sum = 0u64; |
There was a problem hiding this comment.
the sum logic should happen in guest program. the host only does the query
There was a problem hiding this comment.
I'm thinking making host call:
query_balances(variant, account_ids_ptr, bytes_len)(which make host decodeVec<AccountId>'s length) and return slices of balance (write to guest as return values)- or let guest has the type information to decode bytes, then do
query_balance(variant, account_id)
I think the latter will be more general and make the host call api simple.
There was a problem hiding this comment.
Does the prefixed compact-encoded length in SCALE encoding with Vec<T> just for size hint to preallocate appropriate memory? We still need to specify the encoded bytes length when doing decoding, right?
There was a problem hiding this comment.
host function should be minimal
it should be query one account id at a time so and we know the size of AccountId and can just hardcode it here
indirection42
force-pushed
the
poc-query-balance
branch
from
458ccd3
to
ee158cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
poc-guest-query-balance is working, close #2
Bugs:
The previous way of returning value via guest's stack is not working. Specifically, PR #17 has bug, which produce 40 instead of 42 for variant 1. In addition, return RO value is ok for variant 0.
I roughly looked over the assembly code, and it does seem a bit off. I need to take a closer look later.
For now, I use return value via heap instead, it works.