fix: prevent identifier extraction as event names, support custom Event classes#330
Open
binlabs wants to merge 1 commit into
Open
fix: prevent identifier extraction as event names, support custom Event classes#330binlabs wants to merge 1 commit into
binlabs wants to merge 1 commit into
Conversation
✅ Deploy Preview for custom-elements-manifest-analyzer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
0418b54 to
a744989
Compare
a744989 to
c378343
Compare
Author
|
I just realized that naming these fixtures "custom-event" may have been confusing, because they are really subclasses of either So I just renamed the fixtures and amended the commit, just FYI. |
28 tasks
|
We have also noticed this issue with the incorrect __dispatchCustomEvent(eventName, item, value) {
if (!item) {
return;
}
this.dispatchEvent(
new CustomEvent(eventName, {
detail: {
item,
value,
},
}),
);
}IMO it would be good to get this fix merged, maybe it would help to split into 2 PRs. @thepassle WDYT? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #149
new MyEvent(someArg)).super()call.