#850 Scope don't need attributes#853
Open
thompson-tomo wants to merge 1 commit intoopen-telemetry:mainfrom
Open
#850 Scope don't need attributes#853thompson-tomo wants to merge 1 commit intoopen-telemetry:mainfrom
thompson-tomo wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Contributor
|
I still think, as scope is mostly unused in weaver / semconv so far, it'd be nice to understand the plans for defining scope here, as it relates to V2 syntax where we'll have scope more explicit. In fact, I'd prefer if we just don't add dependencies on using Scope in weaver for now until we migrate to V2 schema so we can clean up the YAML more easily. Is there a compelling reason we need to add scope support now? I realize it's a hole in semconv today, but it's been like that for quite some time, I think another few months isn't going to cause significant burdens to semconv. |
Contributor
Author
|
Actually I am not adding support for scopes as that is pre-existing functionality. But just removing the requirement of scopes to have attributes to match the spec. |
0303833 to
85809e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #850
Scope's are no longer required to have attributes as per the specification