Skip to content

Force npm + node versions for UI#1173

Open
jsuereth wants to merge 6 commits intoopen-telemetry:mainfrom
jsuereth:chore-lock-node-version-and-docker-backup
Open

Force npm + node versions for UI#1173
jsuereth wants to merge 6 commits intoopen-telemetry:mainfrom
jsuereth:chore-lock-node-version-and-docker-backup

Conversation

@jsuereth
Copy link
Contributor

@jsuereth jsuereth commented Feb 1, 2026

This Fixes a few things in the build.

  • First it forces a specific version for npm + node - the LTS version
  • Second, it allows cargo to leverage docker in the event your local NPM fails (this may need to be configured better)
  • Finally, this provides a better caching mechanism for cargo so we're not constantly farming out to npm. This is pretty critical for the docker fallback.

This Fixes a few things in the build.

- First it forces a specific version for npm + node - the LTS version
- Second, it allows cargo to leverage docker in the event your local NPM fails (this may need to be configured better)
- Finally, this provides a better caching mechanism for cargo so we're not constantly farming out to `npm`.  This is pretty critical for the docker fallback.
@jsuereth jsuereth requested a review from a team as a code owner February 1, 2026 18:10
@jsuereth
Copy link
Contributor Author

jsuereth commented Feb 1, 2026

@jerbly Could really use your help trying this out.

If I've done this right, then you should have nothing to change because you're on LTS of node. Additionally, any machine that's on a different version will fallback to using docker to pull in the LTS version of node.

PTAL and let me know what you think!

@codecov
Copy link

codecov bot commented Feb 1, 2026

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.9%. Comparing base (0294609) to head (e27e812).

Files with missing lines Patch % Lines
build.rs 0.0% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1173     +/-   ##
=======================================
- Coverage   80.0%   79.9%   -0.1%     
=======================================
  Files        108     109      +1     
  Lines       8440    8447      +7     
=======================================
- Hits        6757    6755      -2     
- Misses      1683    1692      +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jerbly
Copy link
Contributor

jerbly commented Feb 2, 2026

@jsuereth - To have npm ci work I had to match the exact version of npm that's in the docker container, 11.6.2. This is a slightly old version. On 11.8.0, the latest, npm ci fails and therefore falls back to the docker container to build.
So, I would guess that we'll end up always building with the docker container since the version matching seems so exact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants