Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterized query text does not need to be sanitized by default #976

Merged
merged 9 commits into from
May 7, 2024
Merged

Parameterized query text does not need to be sanitized by default #976

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
513ef59
Parameterized query text does not need to be sanitized by default
trask Apr 26, 2024
47688c3
Update PR number
trask Apr 26, 2024
3167fc0
lint
trask Apr 26, 2024
027bde1
lint
trask Apr 29, 2024
ee72eb8
link
trask Apr 29, 2024
184da8a
Update model/trace/database.yaml
trask May 1, 2024
35d16f9
generate
trask May 1, 2024
0f9fa18
Merge remote-tracking branch 'upstream/main' into parameterized-queries
trask May 1, 2024
2bf4529
Merge remote-tracking branch 'upstream/main' into parameterized-queries
trask May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@trask
trask committed Apr 26, 2024
commit 3167fc0ab4dc11d3083674e5f8f305baba754b37
2 changes: 1 addition & 1 deletion model/trace/database.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
recommended: >
Non-parameterized query text SHOULD NOT be collected by default unless there is sanitization that excludes
sensitive data, e.g. by redacting all literal values present in the query text.

Check failure on line 14 in model/trace/database.yaml

View workflow job for this annotation

GitHub Actions / yamllint 

[trailing-spaces] trailing spaces
Parameterized query text SHOULD be collected by default
(the query parameter values themselves are opt-in,
see [`db.query.parameter.<key>`](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/attributes-registry/db.md)).
Expand Down
Loading