Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename db.client.connections.* metrics to db.client.connection.* and rename db.client.connection.usage to db.client.connection.count and adapting units #966

Merged

Conversation

gregkalapos
Copy link
Member

@gregkalapos gregkalapos commented Apr 24, 2024

Fixes #967
Fixes #201
Fixes #381

Changes

As described in #201 and discussed in the DB Semconv Stability WG meeting: db.client.connection.usage -> db.client.connection.count. Also fixing #967 and renaming the db.client.connections.* metrics namespace to db.client.connection.*.

Since this PR already changes Db metrics, also adapting unit from ms to s as described in #381.

Merge requirement checklist

@gregkalapos gregkalapos marked this pull request as ready for review April 24, 2024 20:11
@gregkalapos gregkalapos requested review from a team April 24, 2024 20:11
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it may be worth fixing #967 in this PR also

model/metrics/database-metrics.yaml Outdated Show resolved Hide resolved
model/metrics/database-metrics.yaml Show resolved Hide resolved
@gregkalapos gregkalapos changed the title Rename db.client.connections.usage to db.client.connections.count Rename db.client.connections.* metrics to db.client.connection.* and rename db.client.connection.usage to db.client.connection.count Apr 25, 2024
docs/database/database-metrics.md Outdated Show resolved Hide resolved
model/metrics/database-metrics.yaml Outdated Show resolved Hide resolved
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gregkalapos sorry, I realized it would be good to add one more change to this PR: #381

bundling #381 here would have the advantage that we know the old name is always associated with milliseconds and the new name is always associated with seconds

(and it would affect the schema translation, where the metrics that changed from milliseconds to seconds would no longer be considered renames)

@gregkalapos gregkalapos changed the title Rename db.client.connections.* metrics to db.client.connection.* and rename db.client.connection.usage to db.client.connection.count Rename db.client.connections.* metrics to db.client.connection.* and rename db.client.connection.usage to db.client.connection.count and adapting units Apr 29, 2024
@gregkalapos
Copy link
Member Author

gregkalapos commented Apr 30, 2024

CI fails, dotnet doesn't ❤️ me:

Run dotnet tool update -g docfx --version "3.0.0-*" --add-source https://docfx.pkgs.visualstudio.com/docfx/_packaging/docs-public-packages/nuget/v3/index.json
/tmp/837413a5-82a5-4ef9-abd4-39c1160faf4a/restore.csproj : error NU1102: Unable to find package docfx with version (>= 3.0.0)
/tmp/837413a5-82a5-4ef9-abd4-39c1160faf4a/restore.csproj : error NU1102:   - Found 224 version(s) in nuget.org [ Nearest version: 2.76.0 ]
/tmp/837413a5-82a5-4ef9-abd4-39c1160faf4a/restore.csproj : error NU1102:   - Found 0 version(s) in https://docfx.pkgs.visualstudio.com/docfx/_packaging/docs-public-packages/nuget/v3/index.json
Tool 'docfx' failed to update due to the following:
The tool package could not be restored.
Tool 'docfx' failed to install. This failure may have been caused by:

* You are attempting to install a preview release and did not use the --version option to specify the version.
* A package by this name was found, but it was not a .NET tool.
* The required NuGet feed cannot be accessed, perhaps because of an Internet connection problem.
* You mistyped the name of the tool.

For more reasons, including package naming enforcement, visit https://aka.ms/failure-installing-tool
Error: Process completed with exit code 1.

Update: issue about this: #987

@lmolkova lmolkova merged commit 70baddd into open-telemetry:main May 2, 2024
11 of 12 checks passed
drewby pushed a commit to drewby/otel-semantic-conventions that referenced this pull request May 23, 2024
…and rename `db.client.connection.usage` to `db.client.connection.count` and adapting units (open-telemetry#966)

Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
7 participants