Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename db.statement to db.query.text and introduce db.query.parameter.<key> #866

Merged
merged 15 commits into from
Apr 8, 2024
Merged

Rename db.statement to db.query.text and introduce db.query.parameter.<key> #866

merged 15 commits into from
Apr 8, 2024

Conversation

trask
Copy link
Member

@trask trask commented Apr 2, 2024

Fixes #716

Changes

Renames db.statement to db.query.text and introduces db.query.parameter.<key>.

Merge requirement checklist

@trask trask marked this pull request as ready for review April 2, 2024 02:15
@trask trask requested review from a team April 2, 2024 02:15
lmolkova
lmolkova approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (if db.statement is deprecated )

pyohannes
pyohannes reviewed Apr 4, 2024
View reviewed changes
model/registry/db.yaml Outdated Show resolved Hide resolved
pyohannes
pyohannes approved these changes Apr 5, 2024
View reviewed changes
model/registry/db.yaml Outdated Show resolved Hide resolved
@trask trask requested a review from gregkalapos April 5, 2024 15:34
@gregkalapos gregkalapos mentioned this pull request Apr 5, 2024
Closed
6 tasks
@AlexanderWert AlexanderWert mentioned this pull request Apr 8, 2024
Merged
@lmolkova lmolkova merged commit b5b2409 into open-telemetry:main Apr 8, 2024
12 checks passed
@lmolkova lmolkova mentioned this pull request Apr 18, 2024
Merged
2 tasks
@wertzui wertzui mentioned this pull request Jun 7, 2024
Open
@trask trask deleted the db-query-namespace branch October 14, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flarna Flarna Flarna left review comments

@trisch-me trisch-me trisch-me left review comments

@joaopgrassi joaopgrassi joaopgrassi left review comments

@lmolkova lmolkova lmolkova approved these changes

@jack-berg jack-berg jack-berg approved these changes

@pyohannes pyohannes pyohannes approved these changes

@gregkalapos gregkalapos gregkalapos approved these changes

@AlexanderWert AlexanderWert AlexanderWert approved these changes

Assignees

@joaopgrassi joaopgrassi

Labels
None yet
Projects
Database Client Semantic Conventions
Status: Done
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add attribute db.values to database semantic conventions
9 participants
@trask @AlexanderWert @gregkalapos @lmolkova @joaopgrassi @trisch-me @pyohannes @Flarna @jack-berg