-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLM Semantic Conventions: Initial PR #825
Conversation
Adding OpenAI metrics and fixing markdown errors
81ed4a4
to
b642c4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this initial revision!
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the issues that I had raised earlier.
@nirga are you able to fix the conflicts? I think this looks good to merge :) |
Thanks @joaopgrassi! I've resolved all the comments and fixed the conflicts. I think we're good to go :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm.
A call out I have is that while we specifically only mention LLMs - ML models have been around for a long time - so isn't model observability including LLMs what we want to address with these semantic conventions? Lets discuss in our weekly SIG meeting.
FWIW my take is that scoping to LLMs for now is still the right call, but we should absolutely not design for only them (and I believe that's not happeing). Even in this space, there's multi-modality, language models (like embedding models) that aren't about generating text, diffusion models, etc. The good news is that a lot of the fundamentals around capturing data for various purposes are likely to be similar across many different models types. |
Work towards #327.
Changes
Replacing PRs #639 and #483. Introduces semantic conventions for modern AI systems, following discussions in OpenTelemetry LLM semconv working group.
Merge requirement checklist
[chore]