Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLM Semantic Conventions: Initial PR #825

Merged
merged 47 commits into from
Apr 16, 2024

Conversation

nirga
Copy link
Contributor

@nirga nirga commented Mar 19, 2024

Work towards #327.

Changes

Replacing PRs #639 and #483. Introduces semantic conventions for modern AI systems, following discussions in OpenTelemetry LLM semconv working group.

Merge requirement checklist

@nirga nirga requested review from a team March 19, 2024 11:46
@nirga nirga mentioned this pull request Mar 19, 2024
3 tasks
@nirga nirga force-pushed the first-gen-ai branch 2 times, most recently from 81ed4a4 to b642c4c Compare March 20, 2024 14:12
Copy link

@iag iag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this initial revision!

docs/gen-ai/llm-spans.md Outdated Show resolved Hide resolved
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the issues that I had raised earlier.

docs/gen-ai/llm-spans.md Show resolved Hide resolved
docs/attributes-registry/llm.md Show resolved Hide resolved
@joaopgrassi
Copy link
Member

@nirga are you able to fix the conflicts? I think this looks good to merge :)

@nirga
Copy link
Contributor Author

nirga commented Apr 16, 2024

Thanks @joaopgrassi! I've resolved all the comments and fixed the conflicts. I think we're good to go :)

Copy link
Member

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm.

A call out I have is that while we specifically only mention LLMs - ML models have been around for a long time - so isn't model observability including LLMs what we want to address with these semantic conventions? Lets discuss in our weekly SIG meeting.

@cartermp
Copy link
Contributor

FWIW my take is that scoping to LLMs for now is still the right call, but we should absolutely not design for only them (and I believe that's not happeing). Even in this space, there's multi-modality, language models (like embedding models) that aren't about generating text, diffusion models, etc.

The good news is that a lot of the fundamentals around capturing data for various purposes are likely to be similar across many different models types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.