Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.23.1 schema and prepare changelog for patch release #538

Merged

Conversation

arminru
Copy link
Member

@arminru arminru commented Nov 17, 2023

Related to #533.

@arminru arminru requested review from a team November 17, 2023 13:11
@arminru arminru changed the base branch from main to release/v1.23.x November 17, 2023 13:11
@arminru
Copy link
Member Author

arminru commented Nov 17, 2023

@chalin Will the 1.23.1 schema file on the backport branch release/v1.23.x also be picked up by the website to end up at https://opentelemetry.io/schemas/1.23.1 or would we need to copy the schema file to the main branch here? Thanks!

@chalin
Copy link
Contributor

chalin commented Nov 17, 2023

@chalin Will the 1.23.1 schema file on the backport branch release/v1.23.x also be picked up by the website to end up at https://opentelemetry.io/schemas/1.23.1 or would we need to copy the schema file to the main branch here? Thanks!

If you create a tag v1.23.1 and mark it as the latest release (https://github.com/open-telemetry/semantic-conventions/releases/latest), then the website-repo's auto-update-version script should pick it all up, and the 1.23.1 schema should get published. I can monitor this once 1.23.1 is published.

/cc @svrnm

@chalin
Copy link
Contributor

chalin commented Nov 17, 2023

I'm assuming that eventually these changes will end up on main as well?

@arminru
Copy link
Member Author

arminru commented Nov 17, 2023

@chalin Awesome, thanks for verifying!

The fix PR (#524) was cherry-picked from main already but the changelog update and patched schema file from this PR will only be on release/v1.23.x and tag v1.23.1 for now.

I was thinking of copying them over to main so users can see everything at in one place but I will check with the other @open-telemetry/specs-semconv-maintainers if they agree.

@arminru arminru merged commit 7372058 into open-telemetry:release/v1.23.x Nov 17, 2023
9 checks passed
@arminru arminru deleted the add-1.23.1-schema branch November 17, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants