Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move user agent to registry #418

Merged
merged 8 commits into from
Oct 23, 2023
Merged

move user agent to registry #418

merged 8 commits into from
Oct 23, 2023

Conversation

trisch-me
Copy link
Contributor

@trisch-me trisch-me commented Oct 17, 2023 •
edited by trask
Loading

Changes

Please provide a brief description of the changes here.

  • Moving user agent to the registry
  • Adding 3 new fields from ECS to the registry deferred to follow-up PR

Merge requirement checklist

@trisch-me trisch-me requested review from a team October 17, 2023 11:20
@trisch-me trisch-me requested a review from a team October 17, 2023 12:02
joaopgrassi
joaopgrassi requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@joaopgrassi joaopgrassi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost missed it. Please split the PR and send one to add the new ECS attributes separately. Let's keep moving the attributes to registry a "simple" change.

@trisch-me trisch-me mentioned this pull request Oct 19, 2023
Open
68 tasks
jsuereth
jsuereth reviewed Oct 19, 2023
View reviewed changes
model/registry/user-agent.yaml Outdated Show resolved Hide resolved
model/registry/user-agent.yaml Outdated Show resolved Hide resolved
@trisch-me
Copy link
Contributor Author

trisch-me commented Oct 19, 2023 •
edited
Loading

@joaopgrassi split it, will add new fields in the new PR as soon as this one will be merged

@AlexanderWert
Copy link
Member

nit: @trisch-me please also change the title

@trask trask changed the title move user agent to registry; add new fields from ecs move user agent to registry Oct 20, 2023
@AlexanderWert AlexanderWert merged commit cd04713 into open-telemetry:main Oct 23, 2023
9 checks passed
@trisch-me trisch-me deleted the useragent branch October 23, 2023 11:20
This was referenced Oct 25, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuereth jsuereth jsuereth left review comments

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@AlexanderWert AlexanderWert AlexanderWert approved these changes

@trask trask trask approved these changes

Assignees

@joaopgrassi joaopgrassi

Labels
None yet
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trisch-me @AlexanderWert @jsuereth @trask @joaopgrassi