-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define a common algorithm for service.instance.id #312
Merged
jsuereth
merged 31 commits into
open-telemetry:main
from
jpkrohling:jpkrohling/issue311
Feb 23, 2024
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
62d2150
Define a common algorithm for service.instance.id
jpkrohling fefca87
lint
jpkrohling f18b771
add pid to namespace/name for kubernetes
jpkrohling 8d88ff5
add service.name to machine-id rule
jpkrohling 7133167
use other combinations for uniquely identifying instances
jpkrohling 76ca26f
more clarifications
jpkrohling 67c41d0
determine the UUID's namespace
jpkrohling e7b3256
fix linter
jpkrohling f050618
final clarifications, rebase
jpkrohling 43a6424
s/infered/inferred
jpkrohling e3a3a12
address users of app servers
jpkrohling 4a39b3e
Update with example algorithm in Go
jpkrohling 9d9d1eb
lint
jpkrohling b7339e2
further linting
jpkrohling f184348
service ID MUST wording
jpkrohling 401c260
make namespace optional in some steps of the algorithm
jpkrohling 10e9455
explicit order of priorities
jpkrohling bc1ae47
markdownlint
jpkrohling b2d8a0f
addressed review comments
jpkrohling 84a8e4b
addressed most of Josh's comments
jpkrohling 671c45d
regenerate
jpkrohling 21fa616
tweaks based on the latest revies
jpkrohling e990595
table-generation
jpkrohling f2bfc7e
uuidv4 explicit value
jpkrohling ad3cb3f
add changelog entry
jpkrohling e3b0b3a
add chglog file
jpkrohling becd802
add erlang:node()
jpkrohling dd68f40
simplified the proposal
jpkrohling bcbf475
rewrote paragraph about collector
jpkrohling 6b8421c
further clarified collector and containers
jpkrohling 0538f40
Merge branch 'main' into jpkrohling/issue311
jsuereth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
change_type: 'enhancement' | ||
component: resource | ||
note: Define a common algorithm for `service.instance.id`. | ||
issues: [312] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't understand what it means to "use UUID as the namespace"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UUID v5 has a namespace. Previous versions of the PR had an example showing this, but perhaps this would help see where this namespace is used: https://pkg.go.dev/github.com/google/uuid#NewSHA1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RFC also explains how namespace is used to generate a v5 UUID: https://datatracker.ietf.org/doc/html/rfc4122#page-13