Set span kind on span definitions or change ambiguous spans to attribute groups #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
changed the title
lmolkova
commented
Feb 8, 2025
lmolkova
commented
Feb 8, 2025
This was referenced Feb 8, 2025
trask
approved these changes
Feb 10, 2025
jsuereth
approved these changes
Feb 12, 2025
lmolkova
force-pushed
the
set-span-kind
branch
from
02e7352 to
30369c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1513
In just released weaver 0.13.0 we'll start requiring span kinds. This PR adds span kind to span definitions that describe a single span kind. It changes ambiguous definitions to attribute groups.