Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax server.port requirement level on HTTP server spans #1591

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Relax server.port requirement level on HTTP server spans #1591

merged 3 commits into from
Nov 25, 2024

Conversation

trask
Copy link
Member

@trask trask commented Nov 19, 2024

Fixes #1387

Changes

Relax server.port requirement level on HTTP server spans from

If server.address is set.

to

If available and server.address is set.

@trask trask force-pushed the when-server-port-na branch from 1151c26 to df23b9d Compare November 19, 2024 00:15
@trask trask marked this pull request as ready for review November 19, 2024 00:16
@trask trask requested review from a team as code owners November 19, 2024 00:16
lmolkova
lmolkova approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trask trask mentioned this pull request Nov 19, 2024
Closed
@lmolkova lmolkova enabled auto-merge (squash) November 25, 2024 17:27
@lmolkova lmolkova merged commit 5a13679 into open-telemetry:main Nov 25, 2024
13 of 14 checks passed
@trask trask deleted the when-server-port-na branch January 10, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuereth jsuereth jsuereth approved these changes

@maryliag maryliag maryliag approved these changes

@dyladan dyladan dyladan approved these changes

@lmolkova lmolkova lmolkova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify server.address and server.port in forwarded situations
5 participants
@trask @jsuereth @maryliag @dyladan @lmolkova