Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use project version of markdown-link-check package #1562

Conversation

joaopgrassi
Copy link
Member

Changes

The changelog.yaml workflow is installing the latest version of the markdown-link-check package on each run, and the latest version seems to have a issue (See #1552).

Adding a make target to run this task, so then it uses the version defined in package.json for the repo.

Merge requirement checklist

@joaopgrassi joaopgrassi requested review from a team as code owners November 8, 2024 10:42
@joaopgrassi joaopgrassi changed the title [chore] Use project version of markdown-link-check package Use project version of markdown-link-check package Nov 8, 2024
@joaopgrassi joaopgrassi added Skip Changelog Label to skip the changelog check and removed Skip Changelog Label to skip the changelog check labels Nov 8, 2024
@joaopgrassi joaopgrassi added the Skip Changelog Label to skip the changelog check label Nov 8, 2024
@christophe-kamphaus-jemmic
Copy link
Contributor

Is there a commit on which the changelog workflow succeeded and wasn't skipped?

@joaopgrassi
Copy link
Member Author

Is there a commit on which the changelog workflow succeeded and wasn't skipped?

No. The problem is that I added the new make target, but I can't use it in the workflow yet, since it fails because the new target is not there. So I guess we will only know when it merges. I only tested it locally and all worked.

@joaopgrassi joaopgrassi merged commit 9ef90ae into open-telemetry:main Nov 8, 2024
14 checks passed
@joaopgrassi joaopgrassi deleted the fix-changelog-link-check branch November 8, 2024 16:15
@joaopgrassi
Copy link
Member Author

Let's see if it works 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Label to skip the changelog check
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants