Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

messaging.system support pulsar #1099

Merged
merged 3 commits into from
Jun 5, 2024
Merged

messaging.system support pulsar #1099

merged 3 commits into from
Jun 5, 2024

Conversation

crossoverJie
Copy link
Contributor

Changes

messaging.system support pulsar.

@crossoverJie crossoverJie requested review from a team May 31, 2024 09:26
@lmolkova
Copy link
Contributor

Thank you for the contribution!

We autogenerate (partially) markdown files. Please add pulsar to the list of systems defined in

semantic-conventions/model/registry/messaging.yaml

Line 147 in b56bad3

members:
.

You can then run markdown generation to add pulsar to all docs - check out https://github.com/open-telemetry/semantic-conventions/blob/main/CONTRIBUTING.md#2-update-the-markdown-files

Please also add a changelog entry.

@crossoverJie
Copy link
Contributor Author

Thanks for your guidance, done.

lmolkova
lmolkova approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lmolkova lmolkova merged commit dd277f6 into open-telemetry:main Jun 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyohannes pyohannes pyohannes approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@lmolkova lmolkova lmolkova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crossoverJie @lmolkova @joaopgrassi @pyohannes @arminru