-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Session start and end events #1091
Session start and end events #1091
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One non-blocking question, and a suggestion to mention how the previous session ID can be used to signify that the previous session has ended - but again, non-blocking
2837df6
to
1ce116d
Compare
Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
@breedx-splk I think it would be good to have folks from the event and client working groups to take a look and approve this? Are you in touch with them? We don't seem to have a GitHub team for them so not sure how to get attention. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, left a couple comments. I envision having named sessions in the long term, but it can be added in the future using a session.name
field.
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
3 approvals, are we waiting for anything else on this? 🙏🏻 |
@breedx-splk please resolve open discussions (if they are resolved) and it should be ready to go |
Changes
This serves as an alternative/successor to #1042. Instead of describing a session change event, we have a session start and session end event instead.
Merge requirement checklist
[chore]