-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propose semantic conventions for GCP client library identification #1047
Merged
lmolkova
merged 18 commits into
open-telemetry:main
from
michaelsafyan:gcp-client-libraries
Jun 7, 2024
Merged
Propose semantic conventions for GCP client library identification #1047
lmolkova
merged 18 commits into
open-telemetry:main
from
michaelsafyan:gcp-client-libraries
Jun 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuereth
reviewed
May 20, 2024
lmolkova
reviewed
May 22, 2024
dbolduc
reviewed
May 23, 2024
dbolduc
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Not that this means anything, but) LGTM
lmolkova
reviewed
May 28, 2024
3 tasks
open-telemetry#1047 (comment) Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
open-telemetry#1047 (comment) Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Closed
3 tasks
lmolkova
reviewed
Jun 4, 2024
lmolkova
reviewed
Jun 4, 2024
jsuereth
approved these changes
Jun 7, 2024
lmolkova
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propose semantic conventions for GCP client library identification and attribution.
Changes
Defines a set of
gcp.client.*
scope attributes for identifying Google Cloud client libraries.Merge requirement checklist