Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose semantic conventions for GCP client library identification #1047

Merged
merged 18 commits into from
Jun 7, 2024

Conversation

michaelsafyan
Copy link
Contributor

Propose semantic conventions for GCP client library identification and attribution.

Changes

Defines a set of gcp.client.* scope attributes for identifying Google Cloud client libraries.

Merge requirement checklist

@michaelsafyan michaelsafyan requested review from a team May 17, 2024 16:42
Copy link

linux-foundation-easycla bot commented May 17, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

model/trace/instrumentation/gcp-client.yml Outdated Show resolved Hide resolved
model/trace/instrumentation/gcp-client.yml Outdated Show resolved Hide resolved
model/trace/instrumentation/gcp-client.yml Outdated Show resolved Hide resolved
Copy link

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not that this means anything, but) LGTM

model/registry/gcp.yaml Outdated Show resolved Hide resolved
model/registry/instrumentation.yaml Outdated Show resolved Hide resolved
model/registry/instrumentation.yaml Outdated Show resolved Hide resolved
model/registry/instrumentation.yaml Outdated Show resolved Hide resolved
model/registry/instrumentation.yaml Outdated Show resolved Hide resolved
model/trace/instrumentation/instrumentation.yml Outdated Show resolved Hide resolved
model/registry/instrumentation.yaml Outdated Show resolved Hide resolved
model/registry/instrumentation.yaml Outdated Show resolved Hide resolved
model/registry/instrumentation.yaml Outdated Show resolved Hide resolved
@lmolkova lmolkova merged commit a159095 into open-telemetry:main Jun 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants