-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure SDK attributes & Logs events #1028
Conversation
c66ef64
to
f5967d5
Compare
filled attribute descriptions and examples add changelog clean-up yaml to pass linter add initial description for azure logs markdown more linter appeasing rename azure logs md
f5967d5
to
6f8cb8d
Compare
Hi @lmolkova - please can we get your input on adding these Azure SDK / logs semantic conventions? Thanks 😄 |
Thank you for for working on this! I'll share more comments, but the main question is whether we need to define those as attributes. Logs/events have attributes and payload. We can take azure log as is, document the payload format and send them as is over OTLP with no mapping. Event payload fields can be documented, here's an example, they don't need a namespace. If there are no use-case for these attributes to appear on spans, metrics, resources, then event payload fields would work better. So, was this option was considered? What would be the reasons to send azure logs with those as attributes and not event payload fields? /cc @MSNev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there are two major discussion points:
- whether we need attributes for azure log events or they should be populated as event payload fields (elaborated in the comment above)
- how the actual mapping works - is it possible to document Azure Log Event semconv? What goes into event name, timestamp, severity, payload, attributes, etc
@lmolkova the PR went with attributes because that has been the standard for collector translators/components so far. I believe the I'm not very up-to-date with the event spec. I see it is marked as experimental still, is it changing a lot still? I see this PR as an attempt to provide some clarity/stability for azure -> OTel semantics and I'm wondering if attributes gives more stability than events while azure -> OTel semantics become stable. |
Another question: My understanding is that for any |
58bf06e
to
3f8d012
Compare
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
…onventions into mike/azure-logs
@lmolkova I think this is ready for (hopefully) final review 😢 |
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of cosmetic comments, looks great otherwise!
Updated properties to be a keyvaluelist field type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Fixes #1027, #1299
Changes
Adds the new Azure Logs semantic conventions.
Merge requirement checklist
[chore]
schema-next.yaml updated with changes to existing conventions.