Skip to content

Commit

Permalink
[model/resource] Change host.cpu.model.family and `host.cpu.model.i…
Browse files Browse the repository at this point in the history
…d` to be strings (#499)

Co-authored-by: Joao Grassi <joao.grassi@dynatrace.com>
  • Loading branch information
mx-psi and joaopgrassi authored Nov 13, 2023
1 parent 55a6575 commit f6fec98
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ release.

- Update `jvm.gc.duration` histogram buckets to `[ 0.01, 0.1, 1, 10 ]`
([#317](https://github.com/open-telemetry/semantic-conventions/pull/317))
- BREAKING: Change type of `host.cpu.model.id` and `host.cpu.model.family` to string.
([#495](https://github.com/open-telemetry/semantic-conventions/issues/495))

### Features

Expand Down
4 changes: 2 additions & 2 deletions docs/resource/host.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ To report host metrics, the `system.*` namespace SHOULD be used.
| Attribute | Type | Description | Examples | Requirement Level |
|---|---|---|---|---|
| `host.cpu.cache.l2.size` | int | The amount of level 2 memory cache available to the processor (in Bytes). | `12288000` | Opt-In |
| `host.cpu.family` | int | Numeric value specifying the family or generation of the CPU. | `6` | Opt-In |
| `host.cpu.model.id` | int | Model identifier. It provides more granular information about the CPU, distinguishing it from other CPUs within the same family. | `6` | Opt-In |
| `host.cpu.family` | string | Family or generation of the CPU. | `6`; `PA-RISC 1.1e` | Opt-In |
| `host.cpu.model.id` | string | Model identifier. It provides more granular information about the CPU, distinguishing it from other CPUs within the same family. | `6`; `9000/778/B180L` | Opt-In |
| `host.cpu.model.name` | string | Model designation of the processor. | `11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz` | Opt-In |
| `host.cpu.stepping` | int | Stepping or core revisions. | `1` | Opt-In |
| `host.cpu.vendor.id` | string | Processor manufacturer identifier. A maximum 12-character string. [1] | `GenuineIntel` | Opt-In |
Expand Down
10 changes: 5 additions & 5 deletions model/resource/host.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -106,17 +106,17 @@ groups:
examples: [ 'GenuineIntel' ]
- id: family
requirement_level: opt_in
type: int
type: string
brief: >
Numeric value specifying the family or generation of the CPU.
examples: [ 6 ]
Family or generation of the CPU.
examples: [ '6', 'PA-RISC 1.1e' ]
- id: model.id
requirement_level: opt_in
type: int
type: string
brief: >
Model identifier. It provides more granular information about the CPU, distinguishing it from
other CPUs within the same family.
examples: [ 6 ]
examples: [ '6', '9000/778/B180L' ]
- id: model.name
requirement_level: opt_in
type: string
Expand Down

0 comments on commit f6fec98

Please sign in to comment.