Skip to content

Commit

Permalink
[resource/host] Change type of host.cpu.stepping to string (#665)
Browse files Browse the repository at this point in the history
  • Loading branch information
ChrsMark committed Feb 8, 2024
1 parent e2382e6 commit a78115e
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 4 deletions.
22 changes: 22 additions & 0 deletions .chloggen/fix_cpu_step.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Use this changelog template to create an entry for release notes.
#
# If your change doesn't affect end users you should instead start
# your pull request title with [chore] or use the "Skip Changelog" label.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: "breaking"

# The name of the area of concern in the attributes-registry, (e.g. http, cloud, db)
component: 'host'

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: "[resource/host] Change type of host.cpu.stepping to string"

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
# The values here must be integers.
issues: [664, 665]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
2 changes: 1 addition & 1 deletion docs/attributes-registry/host.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
| `host.cpu.family` | string | Family or generation of the CPU. | `6`; `PA-RISC 1.1e` |
| `host.cpu.model.id` | string | Model identifier. It provides more granular information about the CPU, distinguishing it from other CPUs within the same family. | `6`; `9000/778/B180L` |
| `host.cpu.model.name` | string | Model designation of the processor. | `11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz` |
| `host.cpu.stepping` | int | Stepping or core revisions. | `1` |
| `host.cpu.stepping` | string | Stepping or core revisions. | `1`; `r1p1` |
| `host.cpu.vendor.id` | string | Processor manufacturer identifier. A maximum 12-character string. [1] | `GenuineIntel` |
| `host.id` | string | Unique host ID. For Cloud, this must be the instance_id assigned by the cloud provider. For non-containerized systems, this should be the `machine-id`. See the table below for the sources to use to determine the `machine-id` based on operating system. | `fdbf79e8af94cb7f9e8df36789187052` |
| `host.image.id` | string | VM image ID or host OS image ID. For Cloud, this value is from the provider. | `ami-07b06b442921831e5` |
Expand Down
2 changes: 1 addition & 1 deletion docs/resource/host.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ To report host metrics, the `system.*` namespace SHOULD be used.
| [`host.cpu.family`](../attributes-registry/host.md) | string | Family or generation of the CPU. | `6`; `PA-RISC 1.1e` | Opt-In |
| [`host.cpu.model.id`](../attributes-registry/host.md) | string | Model identifier. It provides more granular information about the CPU, distinguishing it from other CPUs within the same family. | `6`; `9000/778/B180L` | Opt-In |
| [`host.cpu.model.name`](../attributes-registry/host.md) | string | Model designation of the processor. | `11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz` | Opt-In |
| [`host.cpu.stepping`](../attributes-registry/host.md) | int | Stepping or core revisions. | `1` | Opt-In |
| [`host.cpu.stepping`](../attributes-registry/host.md) | string | Stepping or core revisions. | `1`; `r1p1` | Opt-In |
| [`host.cpu.vendor.id`](../attributes-registry/host.md) | string | Processor manufacturer identifier. A maximum 12-character string. [1] | `GenuineIntel` | Opt-In |

**[1]:** [CPUID](https://wiki.osdev.org/CPUID) command returns the vendor ID string in EBX, EDX and ECX registers. Writing these to memory in this order results in a 12-character string.
Expand Down
4 changes: 2 additions & 2 deletions model/registry/host.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,10 @@ groups:
Model designation of the processor.
examples: [ '11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz' ]
- id: cpu.stepping
type: int
type: string
brief: >
Stepping or core revisions.
examples: [ 1 ]
examples: ["1", "r1p1"]
- id: cpu.cache.l2.size
type: int
brief: >
Expand Down

0 comments on commit a78115e

Please sign in to comment.