Skip to content

Commit

Permalink
rename published to produced
Browse files Browse the repository at this point in the history
  • Loading branch information
lmolkova committed May 9, 2024
1 parent 448b97e commit 18f8142
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .chloggen/1006.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ note: |
Support generic operations in messaging rename_metrics:
- Deprecate `messaging.operation.type` in favor of now required `messaging.operation.name`.
- Rename `messaging.publish.messages` to `messaging.client.published.messages`
- Rename `messaging.publish.messages` to `messaging.client.produced.messages`
- Rename `messaging.process.duration` to `messaging.client.process.duration`
- Unify `messaging.publish.duration` and `messaging.receive.duration` into `messaging.client.operation.duration`
- Unify `messaging.receive.messages` and `messaging.process.messages` into `messaging.client.consumed.messages`
Expand Down
8 changes: 4 additions & 4 deletions docs/messaging/messaging-metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
- [Common attributes](#common-attributes)
- [Metric: `messaging.client.operation.duration`](#metric-messagingclientoperationduration)
- [Producer metrics](#producer-metrics)
- [Metric: `messaging.client.published.messages`](#metric-messagingclientpublishedmessages)
- [Metric: `messaging.client.produced.messages`](#metric-messagingclientproducededmessages)
- [Consumer metrics](#consumer-metrics)
- [Metric: `messaging.client.consumed.messages`](#metric-messagingclientconsumedmessages)
- [Metric: `messaging.client.process.duration`](#metric-messagingclientprocessduration)
Expand Down Expand Up @@ -113,14 +113,14 @@ of `[ 0.005, 0.01, 0.025, 0.05, 0.075, 0.1, 0.25, 0.5, 0.75, 1, 2.5, 5, 7.5, 10

## Producer metrics

### Metric: `messaging.client.published.messages`
### Metric: `messaging.client.produced.messages`

This metric is [required][MetricRequired].

<!-- semconv metric.messaging.client.published.messages(metric_table) -->
<!-- semconv metric.messaging.client.produced.messages(metric_table) -->
| Name | Instrument Type | Unit (UCUM) | Description | Stability |
| -------- | --------------- | ----------- | -------------- | --------- |
| `messaging.client.published.messages` | Counter | `{message}` | Measures the number of published messages. | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| `messaging.client.produced.messages` | Counter | `{message}` | Measures the number of produced messages. | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
<!-- endsemconv -->

## Consumer metrics
Expand Down
4 changes: 2 additions & 2 deletions model/metrics/deprecated/messaging-metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ groups:
- id: metric.messaging.publish.messages
type: metric
metric_name: messaging.publish.messages
brief: "Deprecated. Use `messaging.client.published.messages` instead."
deprecated: "Replaced by `messaging.client.published.messages`."
brief: "Deprecated. Use `messaging.client.produced.messages` instead."
deprecated: "Replaced by `messaging.client.produced.messages`."
stability: experimental
instrument: counter
unit: "{message}"
Expand Down
6 changes: 3 additions & 3 deletions model/metrics/messaging-metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ groups:
extends: metric.messaging.attributes

# counters
- id: metric.messaging.client.published.messages
- id: metric.messaging.client.produced.messages
type: metric
metric_name: messaging.client.published.messages
brief: "Measures the number of published messages."
metric_name: messaging.client.produced.messages
brief: "Measures the number of produced messages."
stability: experimental
instrument: counter
unit: "{message}"
Expand Down
2 changes: 1 addition & 1 deletion schema-next.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ versions:
changes:
# https://github.com/open-telemetry/semantic-conventions/pull/1006
- rename_metrics:
messaging.publish.messages: messaging.client.published.messages
messaging.publish.messages: messaging.client.produced.messages
messaging.process.duration: messaging.client.process.duration
# https://github.com/open-telemetry/semantic-conventions/pull/1006
- rename_attributes:
Expand Down

0 comments on commit 18f8142

Please sign in to comment.