This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 164
Stabilize messaging semantic conventions for tracing #192
Closed
Closed
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
03d8291
Messaging semantic conventions for tracing, first draft
pyohannes 13c975d
Change name to PR request id
pyohannes 8f4349f
Update text/trace/0192-messaging-semantic-conventions-spec.md
pyohannes 98cf8f3
PR comments
pyohannes 2d8f25c
PR comments
pyohannes f48379f
Add first draft for consumer instrumentation span structure
pyohannes 5e67b1f
Fix spelling
pyohannes 7b2dbe9
PR comments
pyohannes f23c5ac
Rename the "Receive" span to "Deliver"
pyohannes 51501ce
Push and pull based consumer scenarios
pyohannes 20f272c
Remove obsolete text
pyohannes 1e14ff0
Clarify context propagation
pyohannes b87adf6
Fix markdownlint errors
pyohannes 20887d2
Add links
pyohannes 2ae923d
PR comments
pyohannes 0e8f824
Producer scenarios
pyohannes 161392e
Remove trailing whitespace
pyohannes f40ff57
Fix wording
pyohannes 523c435
Add examples
pyohannes 4d341f6
Fix examples
pyohannes 4615994
Add draft for settlement instrumentation
pyohannes 71e5ab8
Complete settlement section
pyohannes b316b1a
Add details about span kinds and names
pyohannes bcd328e
Fix markdown lint error
pyohannes 0e4a777
Update text/trace/0192-messaging-semantic-conventions-spec.md
pyohannes d91ac98
Update text/trace/0192-messaging-semantic-conventions-spec.md
pyohannes 40c1d13
Add first attributes
pyohannes e2738c6
Avoid using the term "client"
pyohannes 9055167
Add TOC
pyohannes 8e663f0
Add more attributes
pyohannes 7c1d84c
Add network transport attributes
pyohannes 38dc813
Update text/trace/0192-messaging-semantic-conventions-spec.md
pyohannes 92a1dd5
Update text/trace/0192-messaging-semantic-conventions-spec.md
pyohannes 8dc5b9f
Apply suggestions from code review
pyohannes 72e1215
PR comments
pyohannes e4ccef0
Merge branch 'main' into conventions-messaging
joaopgrassi 5fa715d
PR suggestions and grammar fixes
joaopgrassi 8b4461a
Make messaging.system attribute level required
joaopgrassi 964d65e
Set requirement level for destination.temporary and anonymous
joaopgrassi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix wording
- Loading branch information
commit f40ff576a53a9a2788d10be7b519d9725b2c5445
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"duration of the call or operation that provides messages for sending" ... what does it actually mean?
For example, with the Kafka producer, the
send
method is just a way to put the message in a buffer and it will be sent asynchronously (even because it works by using batches). Does the span measure only the time to call thesend
and exit? What if the producer wants a level of acknowledge waiting for the ack (so the Kafka producer has also a callback for that)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My interpretation is that it's "vague" intentionally. In my view it can mean/cover all of the scenarios you brought. The problem is that it can't enforce anything and since it changes between systems + what instrumentations can do I'm not sure if we should be highly specific here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a suggestion to list the scenarios.