Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop old and add new Java docs submodule #995

Merged
merged 4 commits into from
Dec 20, 2021
Merged

Drop old and add new Java docs submodule #995

merged 4 commits into from
Dec 20, 2021

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Dec 20, 2021 •
edited
Loading

@chalin chalin requested review from a team and austinlparker December 20, 2021 19:50
@chalin
Copy link
Contributor Author

chalin commented Dec 20, 2021

/cc @cartermp

cartermp
cartermp approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks good on the deployed preview (and refreshed docs, yay!)

@chalin chalin mentioned this pull request Dec 20, 2021
Closed
@chalin
Copy link
Contributor Author

chalin commented Dec 20, 2021

Thanks for the review and approval @cartermp. Merging ...

@chalin chalin merged commit a4a6f61 into open-telemetry:main Dec 20, 2021
@chalin chalin deleted the chalin-new-java-submodule-2021-12-20 branch December 20, 2021 19:54
@chalin chalin mentioned this pull request Dec 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@austinlparker austinlparker Awaiting requested review from austinlparker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @cartermp