Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[es] Spanish folder localization docs/kubernetes #5227 #5301

Closed
wants to merge 25 commits into from

Conversation

Victorsesan
Copy link

@Victorsesan Victorsesan commented Oct 3, 2024

I have translated the following page opentelemetry.io/content/en/docs/kubernetes/getting-started.md and created a new page opentelemetry.io/content/es/docs/kubernetes/getting-started.md

Relates to #5227

…s/kubernetes/getting-started.md and created a new page opentelemetry.io/content/es/docs/kubernetes/getting-started.md
@Victorsesan Victorsesan requested a review from a team as a code owner October 3, 2024 21:51
@opentelemetrybot opentelemetrybot requested review from a team October 3, 2024 21:51
@opentelemetrybot opentelemetrybot requested review from krol3 and removed request for a team October 3, 2024 21:52
…s/kubernetes/helm, he traducido la siguiente página opentelemetry.io/content/en/docs/kubernetes/helm/_index.md y creado una nueva página opentelemetry.io/content/es/docs/kubernetes/helm/_index.md
@opentelemetrybot opentelemetrybot requested review from a team October 3, 2024 22:20
…ernetes/helm/collector.md y creado una nueva página opentelemetry.io/content/es/docs/kubernetes/helm/collector.md
@theletterf
Copy link
Member

Thanks, @Victorsesan! Please add the related issue to the description.

content/es/docs/kubernetes/getting-started.md Outdated Show resolved Hide resolved
content/es/docs/kubernetes/getting-started.md Outdated Show resolved Hide resolved
…oraciones corregidas a segunda persona singular. Abierto para más corrección/sugerencia si hay algún agradecimiento
@opentelemetrybot opentelemetrybot requested review from a team October 4, 2024 17:41
@theletterf
Copy link
Member

/fix:format

@opentelemetrybot
Copy link
Collaborator

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11194616968

@opentelemetrybot
Copy link
Collaborator

fix:format was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@theletterf
Copy link
Member

@Victorsesan Seems like the issues persist. Let me know if you need assistance or comment in the channel.

@Victorsesan
Copy link
Author

@theletterf Sí, gracias por preguntar, lo siento, no quería ser un problema para hacer demasiadas preguntas para un problema básico como este. El primer problema que tuve fue encontrar la clave hash. El enlace solo describía cómo agregar default_lang_commit pero no mencionaba cómo encontrarlo, así que usé git log -1 --format="%H para encontrar la última clave hash de commit y la usé como default_lang_commit en cada archivo que no estoy seguro de que fuera el método correcto para obtener la clave hash, así que cualquier ayuda en esta área sobre cómo encontrar la clave hash será apreciada. Además, el registro de errores de escritura se refiere a líneas incorrectas, lo que dificulta saber qué línea se encuentra exactamente el error de escritura. Gracias

@theletterf
Copy link
Member

@krol3 Could you help Victor? Thanks!

@Victorsesan
Copy link
Author

@theletterf Had made some translations and opened a PR , will be awaiting expected test results for alteration👍

@theletterf
Copy link
Member

@Victorsesan I see some fields in the frontmatter translated to Spanish, like linkTítulo -- please don't translate frontmatter setting names. Also, check the hashes, as they might differ for each page.

Victorsesan and others added 2 commits November 10, 2024 02:05
Ref [es] Spanish folder localization docs/kubernetes #5227
@Victorsesan
Copy link
Author

@Victorsesan I see some fields in the frontmatter translated to Spanish, like linkTítulo -- please don't translate frontmatter setting names. Also, check the hashes, as they might differ for each page.

Thanks for reviewing, i have had them sorted. Also i have been wondering are the methods to check default language commit in the Contribution.md really up to date 🤔, maybe is just me or i haven't been doing it right but each time i run something like npm run check:i18n -- -n i always get this error of 'scripts' not recognized as an internal or external command, operable program or batch file, and thesame even while trying the other commands.

So far i have been using this rather git log -1 --format="%H" which provides a hash but I'm not sure if it works thesame as that which was written in the contribution.md, and unfortunately i couldn't get the hash of each page with it. Hoping to get a better understanding on how this work so i can have everything sorted out as requested thanks

@theletterf
Copy link
Member

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11766855614

@opentelemetrybot
Copy link
Collaborator

fix:all failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/11766855614.

@theletterf
Copy link
Member

/fix:htmltest-config

@opentelemetrybot
Copy link
Collaborator

You triggered fix:htmltest-config action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11766902093

@opentelemetrybot
Copy link
Collaborator

fix:htmltest-config was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@theletterf
Copy link
Member

/fix:format

@opentelemetrybot
Copy link
Collaborator

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11766925252

@opentelemetrybot
Copy link
Collaborator

fix:format was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@theletterf
Copy link
Member

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11766933736

@opentelemetrybot
Copy link
Collaborator

fix:all failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/11766933736.

@theletterf
Copy link
Member

@Victorsesan I'm closing this PR. It has too many faults to fix, including automated translations that weren't checked by a human, such as "coleccionista" instead of "Collector". This is not the right way of localizing content.

Please, try again with fewer files and following all the recommendations in

@theletterf theletterf closed this Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants