-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenTelemetry Protocol with Apache Arrow in Production #5198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass edits - had to stop around line 92. Will do more next week! Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this, great read. My main question is around "OTAP" vs "OTel-Arrow", are those 2 things different? So is it "OTel-Arrow Receiver" or "OTAP Receiver" like "OTLP receiver".
Also, a question on where this content should live: there is a lot of practical material in the content, that looks more like docs dann a blog. Is OTel Arrow ready for production such that we can take some of that into the documentation (e.g. within the collector docs)?
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
Co-authored-by: Severin Neumann <neumanns@cisco.com>
Co-authored-by: Severin Neumann <neumanns@cisco.com>
@svrnm About the length -- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Joshua
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm overall, most comments are suggestions. There is only one around the "collaboration with F5" wording, see my inline comment
Co-authored-by: Severin Neumann <neumanns@cisco.com>
…o jmacd/otelarrowprod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember changing this file. Is it OK?
Hi @jmacd, thanks for your patience. Most of our maintainers are out of the office at the moment. Once they're back, we'll work to get this blog post merged ASAP. As for the submodule file, it should not be included with the PR. If you're able to remove the changes locally, please go ahead. If that's not possible, the docs maintainers will know how to handle the unintended changes. |
You should be able to fix this by |
…o jmacd/otelarrowprod
…elemetry.io into jmacd/otelarrowprod
|
Perfect.
That's unrleated to your PR unfortunately. We have turned on merge queues recently and apparently didn't set it up properly, so CI is running but not failing and still merging PRs with errors. Ignore it for now. |
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11020834246 |
fix:all failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/11020834246. |
/fix:submodules |
You triggered fix:submodules action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11020902472 |
fix:submodules failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/11020902472. |
Signed-off-by: svrnm <neumanns@cisco.com>
@jmacd I fixed the issue with the git submodules. It took me a few tries, so apologies for the commit & message pollution. Eventually the solution was:
|
Fixes #5193.