Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add registry tip to ocb #5028

Merged
merged 10 commits into from
Sep 30, 2024
Merged

Add registry tip to ocb #5028

merged 10 commits into from
Sep 30, 2024

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Aug 13, 2024

A small addition to the collector builder documentation, that the registry can be used to find configuration for components.

@svrnm
Add registry tip to ocb
d3060b9 
Signed-off-by: svrnm <neumanns@cisco.com>
@svrnm svrnm requested a review from a team August 13, 2024 08:02
@opentelemetrybot opentelemetrybot requested a review from a team August 13, 2024 08:02
@opentelemetrybot opentelemetrybot requested review from atoulme and removed request for a team August 13, 2024 08:02
theletterf
theletterf reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of wording suggestions

content/en/docs/collector/custom-collector.md Outdated Show resolved Hide resolved
content/en/docs/collector/custom-collector.md Outdated Show resolved Hide resolved
@svrnm @theletterf
Apply suggestions from code review
c12c36d 
Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
@svrnm
Copy link
Member Author

svrnm commented Sep 5, 2024

@open-telemetry/collector-approvers PTAL

@opentelemetrybot opentelemetrybot requested a review from a team September 5, 2024 14:53
chalin
chalin reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyedits

content/en/docs/collector/custom-collector.md Outdated Show resolved Hide resolved
@theletterf
Copy link
Member

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10726540918

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@svrnm @jpkrohling
Apply suggestions from code review
8e2489f 
Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>
@opentelemetrybot opentelemetrybot requested review from a team September 6, 2024 09:17
@svrnm
fix submodules
0cdf189 
Signed-off-by: svrnm <neumanns@cisco.com>
@svrnm
Merge branch 'main' into add-ocb-tip
d11a90d
@svrnm @chalin
Update content/en/docs/collector/custom-collector.md
2864668 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@opentelemetrybot opentelemetrybot requested a review from a team September 9, 2024 08:48
chalin
chalin approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased, and some checks fixed, but otherwise LGTM

@svrnm svrnm requested a review from a team as a code owner September 30, 2024 08:09
@svrnm
Copy link
Member Author

svrnm commented Sep 30, 2024

/fix:all

@opentelemetrybot opentelemetrybot requested a review from a team September 30, 2024 08:09
@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11102025431

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@svrnm svrnm added this pull request to the merge queue Sep 30, 2024
Merged via the queue into open-telemetry:main with commit 27efc60 Sep 30, 2024
5 checks passed
@svrnm svrnm deleted the add-ocb-tip branch September 30, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theletterf theletterf theletterf left review comments

@mx-psi mx-psi mx-psi approved these changes

@chalin chalin chalin approved these changes

@codeboten codeboten codeboten approved these changes

@jpkrohling jpkrohling jpkrohling approved these changes

@atoulme atoulme Awaiting requested review from atoulme

Assignees
No one assigned
Labels
registry sig:collector
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@svrnm @theletterf @opentelemetrybot @jpkrohling @codeboten @chalin @mx-psi