Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semantic-conventions version to v1.27.0 #4938

Merged

Conversation

opentelemetrybot
Copy link
Collaborator

Update semantic-conventions version to v1.27.0.

See https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.27.0.

@opentelemetrybot opentelemetrybot requested review from a team August 2, 2024 16:17
@chalin chalin self-assigned this Aug 2, 2024
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like some links need to be manually fixed. I'm investigating.

@chalin
Copy link
Contributor

chalin commented Aug 2, 2024

There are invalid anchor ID in the semconv docs, for details, see:

I'll be fixing the other issues shortly.

@opentelemetrybot opentelemetrybot requested a review from a team August 2, 2024 18:03
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks are passing now. Had to patch the adjust-pages.pl script.

@open-telemetry/docs-ja-approvers - can I get a second approval here, thx.

/cc @open-telemetry/specs-semconv-approvers

@chalin
Copy link
Contributor

chalin commented Aug 2, 2024

All GH checks are passing. Netlify build seems to be stuck (since over an hour ago). I'm going to merge now, and will double check that the main build is ok.

Heads up that that I have some cleanup to do in the adjust-pages.pl script. I'll do that in a followup PR.

@chalin chalin merged commit 310fb68 into main Aug 2, 2024
18 of 19 checks passed
@chalin chalin deleted the opentelemetrybot/auto-update-semantic-conventions-v1.27.0 branch August 2, 2024 20:31
@chalin
Copy link
Contributor

chalin commented Aug 2, 2024

Hmm, the build is green https://app.netlify.com/teams/opentelemetry/builds/66ad423d73551f00087eb5d7:

image

But there are a bunch of external links that don't show up in the refcache. I'll investigate that separately.

@chalin
Copy link
Contributor

chalin commented Aug 2, 2024

FYI, the followup issue (unrelated to this PR) is:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants