-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go code excerpts #4678
Update go code excerpts #4678
Conversation
Signed-off-by: svrnm <neumanns@cisco.com>
This seems wrong, as it removes the log example. |
I was surprised about that myself... wait I might have something wrong locally. |
Signed-off-by: svrnm <neumanns@cisco.com>
@@ -409,30 +401,6 @@ func init() { | |||
panic(err) | |||
} | |||
} | |||
|
|||
func rolldice(w http.ResponseWriter, r *http.Request) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been moved to https://github.com/open-telemetry/opentelemetry-go/blob/main/example/dice/rolldice.go so we need to update the documentation accordingly
turning this into a draft for now, this needs more thought than I initially anticipated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @svrnm. Btw, this sort of experience goes to show that we can automate the code-snippet refresh (which is super great for minor changes), but when major structural changes are involved, we still need to carefully address the changes in the prose.
/cc @zeitlinger
for java, I have created a dedicated |
Can you share that project? |
|
Will raise a new PR because of #4679 |
I ran
npm run codeexcerpts
to apply latest changes to the go examples, I think this is one of the first times we do the update, so please take a close look