Add default Collector configuration path to Configuration docs #3940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theletterf
requested review from
a team and
codeboten
and removed request for
a team
svrnm
reviewed
Feb 5, 2024
svrnm
reviewed
Feb 5, 2024
…m:open-telemetry/opentelemetry.io into theletterf-3929-add-collector-config-path
|
PTAL. I've made the override examples more realistic and edited the location paragraph to make it a bit more... flexible. |
mx-psi
reviewed
Feb 6, 2024
Comment on lines
+883
to
+890
| ```shell | ||
| # The following example sets the verbosity | ||
| # level of the debug exporter to 'detailed' | ||
| otelcol --set "exporters::debug::verbosity=detailed" | ||
| # The following example overrides gRPC | ||
| # settings for the OTLP receiver | ||
| otelcol --set "receivers::otlp::protocols::grpc={endpoint:localhost:4317, compression: gzip}" | ||
| ``` |
There was a problem hiding this comment.
@bogdandrutu do you think having these examples make sense?
There was a problem hiding this comment.
If they're syntactically correct, could we merge and review later?
There was a problem hiding this comment.
Sweet! Could you approve? Thanks!
svrnm
approved these changes
Feb 6, 2024
mx-psi
approved these changes
Feb 7, 2024
svrnm
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3929. Preview: https://deploy-preview-3940--opentelemetry.netlify.app/docs/collector/configuration/
I've added two new sections:
--setoption.Most of the information was taken from https://github.com/open-telemetry/opentelemetry-collector/blob/fa1b24184cb20ed0584457ea68c49c908da5f988/service/README.md?plain=1#L5, assuming that it applies to the
otelcolbinary as well, though confirmation is required.Some questions:
otelcorecolREADME file apply?Note: It'd be really, really great to revive open-telemetry/opentelemetry-collector#5654