Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schemas: add /schemas/list page, and custom 404 for /schemas and missing subpages #3508

Closed

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Nov 7, 2023

@svrnm @tigrannajaryan I think that this is most likely the solution that could meet all of our concerns, as summarized by @svrnm. Here is what this PR offers:

Previews

Redirect tests

Status tests

$ curl -sI https://deploy-preview-3508--opentelemetry.netlify.app/schemas | grep -E 'HTTP|-type|location' 
HTTP/2 404 
content-type: text/html; charset=UTF-8
$ curl -sI https://deploy-preview-3508--opentelemetry.netlify.app/schemas/ | grep -E 'HTTP|-type|location'
HTTP/2 404 
content-type: text/html; charset=UTF-8
$ curl -sI https://deploy-preview-3508--opentelemetry.netlify.app/schemas/list/ | grep -E 'HTTP|-type|location' 
HTTP/2 200 
content-type: text/html; charset=UTF-8

Screenshots

404 page:

image

List page:

image

@chalin chalin requested a review from a team November 7, 2023 12:13
@chalin chalin mentioned this pull request Nov 7, 2023
2 tasks
@chalin chalin force-pushed the chalin-im-schemas-list-2023-11-07 branch 5 times, most recently from 2b58499 to 925eac0 Compare November 7, 2023 14:45
@chalin chalin changed the title Schemas: add list page, and custom 404 Schemas: add /schemas/list page, and custom 404 for /schemas and missing subpages Nov 7, 2023
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, some minor suggestions

@chalin chalin force-pushed the chalin-im-schemas-list-2023-11-07 branch from f191c90 to 16b6215 Compare November 14, 2023 09:41
@chalin
Copy link
Contributor Author

chalin commented Nov 14, 2023

@chalin chalin closed this Nov 14, 2023
@chalin chalin deleted the chalin-im-schemas-list-2023-11-07 branch November 14, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/schemas is the top 404 Right nav formatting problem when page has no TOC
2 participants