Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add updated content for new demo release #3486

Merged
merged 13 commits into from
Nov 7, 2023

Conversation

@austinlparker austinlparker requested review from a team November 3, 2023 14:09
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few copyedits.

You might want to search-and-replace: s/ -- / — /g.

content/en/blog/2023/otel-demo-16.md Outdated Show resolved Hide resolved
content/en/blog/2023/otel-demo-16.md Outdated Show resolved Hide resolved
content/en/blog/2023/otel-demo-16.md Outdated Show resolved Hide resolved
content/en/blog/2023/otel-demo-16.md Outdated Show resolved Hide resolved
content/en/blog/2023/otel-demo-16.md Outdated Show resolved Hide resolved
content/en/blog/2023/otel-demo-16.md Outdated Show resolved Hide resolved
content/en/blog/2023/otel-demo-16.md Outdated Show resolved Hide resolved
content/en/blog/2023/otel-demo-16.md Outdated Show resolved Hide resolved
content/en/blog/2023/otel-demo-16.md Outdated Show resolved Hide resolved
@chalin
Copy link
Contributor

chalin commented Nov 3, 2023

/fix:format

austinlparker and others added 10 commits November 4, 2023 11:02
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@cartermp
Copy link
Contributor

cartermp commented Nov 4, 2023

Looks like action won't kick in :/

@chalin
Copy link
Contributor

chalin commented Nov 4, 2023

Yeah, I'm suspecting that it's a permissions issue with the GH action. What we need is a real OTel bot with all the necessary permissions. Maybe @trask can offer guidance :).

Signed-off-by: svrnm <neumanns@cisco.com>
@cartermp
Copy link
Contributor

cartermp commented Nov 7, 2023

Merging when green, as the upstream has already been released

@cartermp cartermp merged commit 8a3891c into open-telemetry:main Nov 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants