-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update semantic-conventions #2982
Update semantic-conventions #2982
Conversation
FYI, I'm working on fixing links. Wanted to get the preview out ASAP. |
If it helps, I had a few of my own link fixed here: https://github.com/jsuereth/opentelemetry.io/pull/new/wip-bump-semconv |
24961a6
to
9fdd3d9
Compare
All done, thanks! |
Oh cool, you actually added custom frontmatter @jsuereth! Ok, let me use that too! |
There will be followup PRs, but this is ready to go @jsuereth. |
@jsuereth - if you agree to this being merged, please acknowledge that you've read the IMPORTANT NOTE in the opening comment, and agree with the semconv pages being published. |
A few fixes that should land before the semconv pages are published: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving my approval on the general website structure for the semconv. Looks really nice!
@chalin I'd like to actually only publish a stable tag to the website if we can (and make sure the website shows that stable version). Is there more work required to do that? Given how the website looks with this PR though, I'm comfortable removing this as a blocker for releasing the semconv repository and then we can update this to pull in that known version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also wanted to comment, if you'd like to publish this now and add in a version as soon as we have our first release, I'm also ok with that timing.
9409d48
to
95635ea
Compare
@jsuereth - Ok, here's what I've done: I've kept the Once the build is green, since this PR has your and other approvals, I'll merge. |
Thanks for all the hard work @chalin ! This is really looking great! |
/docs/specs/semconv
using the new organization brought in by Renamedspecification
andsemantic_conventions
tomodel
anddocs
semantic-conventions#166Preview: https://deploy-preview-2982--opentelemetry.netlify.app/docs/specs/semconv/