Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SemConv spec under docs/specs (preview) #2920

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 27, 2023

Preview: https://deploy-preview-2920--opentelemetry.netlify.app/docs/specs/semconv/

/cc @jsuereth @joaopgrassi

@chalin chalin requested review from jsuereth, joaopgrassi and a team June 27, 2023 21:12
@chalin chalin force-pushed the chalin-im-semconv-spec-2023-06-27 branch from ce8c83f to 9d55c57 Compare June 27, 2023 21:19
@chalin chalin marked this pull request as draft June 27, 2023 21:24
@chalin
Copy link
Contributor Author

chalin commented Jun 27, 2023

Thanks for the review @cartermp! Will wait for feedback from @jsuereth and @joaopgrassi.

@cartermp
Copy link
Contributor

Yep, figured as much

@chalin chalin marked this pull request as ready for review June 27, 2023 21:52
Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, given things will change after #137.

One question though: Do you think the structure defined here open-telemetry/semantic-conventions#137 (comment) is possible to reproduce on the website? Or: Does it even make sense to you?

content/en/docs/specs/semconv/_index.md Outdated Show resolved Hide resolved
content/en/docs/specs/semconv/_index.md Outdated Show resolved Hide resolved
@@ -185,6 +185,14 @@ module:
target: content/docs/specs/otlp/_index.md
- source: tmp/otlp/docs/img
target: content/docs/specs/otlp/img
- source: tmp/semconv/specification/logs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going through a refactoring of the semantic conventions markdown right now.

Can we just mount tmp/semconv/specification? There will be a top-level readme file there shortly and I'm happy to give it all the hugo content you need.

We do not want to have logs/metrics/trace specific locations going forward.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've answered further below.

@chalin
Copy link
Contributor Author

chalin commented Jun 28, 2023

Do you think the structure defined here open-telemetry/semantic-conventions#137 (comment) is possible to reproduce on the website?

@joaopgrassi - yes, it will actually be easier to bring in. This is just a preview of what it would look like under the current organization.

We're going through a refactoring of the semantic conventions markdown right now.

Can we just mount tmp/semconv/specification? There will be a top-level readme file there shortly and I'm happy to give it all the hugo content you need.

We do not want to have logs/metrics/trace specific locations going forward.

@jsuereth - right, this PR is just in preparation, while open-telemetry/semantic-conventions#137 is being addressed.

I'd you agree (and approve this PR @jsuereth), I'd like to merge this PR As I mentioned earlier, the semconv spec will not show up in production. As work progresses on in the semconv repo, I can submit followup PRs.

@chalin chalin force-pushed the chalin-im-semconv-spec-2023-06-27 branch from 323326f to d03053e Compare June 28, 2023 12:25
@chalin
Copy link
Contributor Author

chalin commented Jun 28, 2023

@jsuereth @joaopgrassi - btw, regarding the linkTitle, which only shows up in the sidenav: the reason I chose SemConv as a side-nav title is so we can avoid word-wrap (as you can see below), and because it is more consistent with the other specs. If we use the full name "Semantic Conventions", plus the version, it's a bit too wide IMHO:

image

It's a detail, not very important, but I wanted to at least explain why so that you can make a more informed choice of what you'd like the linkTitle to be.

@jsuereth
Copy link

FYI - This relates to the previous PR in this chain, but something we should fix ASAP: open-telemetry/opentelemetry-specification#3572

@joaopgrassi
Copy link
Member

joaopgrassi commented Jun 28, 2023

btw, regarding the linkTitle, which only shows up in the sidenav: the reason I chose SemConv as a side-nav title is so we can avoid word-wrap (as you can see below), and because it is more consistent with the other specs. If we use the full name "Semantic Conventions", plus the version, it's a bit too wide IMHO:

I see. I think the word wrap isn't great, but I think I prefer that over the "cryptic" SemConv one. But even in my 1080p monitor there was no wrap, so should be OK? I guess if it comes to that, we can do some css magic :D

@joaopgrassi
Copy link
Member

joaopgrassi commented Jun 28, 2023

Also: We will be listing under "Semantic Conventions" just the "latest version" right? We will not have something like

Semantic Conventions
- 1.22.0
- 1.23.0
...

@chalin
Copy link
Contributor Author

chalin commented Jun 28, 2023

@joaopgrassi - correct, only the latest officially released version (at least, that is what we're doing with the OTel spec, and we can do the same here).

@chalin chalin force-pushed the chalin-im-semconv-spec-2023-06-27 branch from d03053e to 82c1160 Compare June 28, 2023 13:17
@chalin
Copy link
Contributor Author

chalin commented Jun 28, 2023

@jsuereth - so, is this preview PR good to go?

Copy link

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under the caveat that we'll change the import going forward for new layout, yeah, let's keep making steady progress.

I do have a few question for follow up PRs:

  • How do we get left-hand outline like the spec has for sections?
  • Can we change all links to specification in semconv to point at the otel.io copy of the specification?
  • Can we change all links to semconv from the specification to point at the otel.io copy of the semconv?

For the last two I was working on the perl script to make this happen.

@chalin chalin merged commit c88aad5 into open-telemetry:main Jun 28, 2023
6 checks passed
@chalin chalin deleted the chalin-im-semconv-spec-2023-06-27 branch June 28, 2023 14:52
@chalin
Copy link
Contributor Author

chalin commented Jun 28, 2023

@jsuereth - I've answered in #2721 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants