New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: warn about external links to local pages rather than abort with an error #2497

Merged

chalin merged 1 commit into open-telemetry:main from chalin:chalin-im-warn-about-ext-url-2023-03-13

Mar 13, 2023

Contributor

chalin commented Mar 13, 2023 •

edited

Loading

The site build fails under Windows, apparently because of the difference in behavior of the adjust-pages.pl script.
For now, turn those errors into warnings. I'll reintroduce the errors separately, via: Make build and CI more contributor friendly #2448
Contributes to Make build and CI more contributor friendly #2448

/cc @svrnm @tsloughter


          CI: warn about external links to local pages rather than abort with a…

ffdf113

…n error

chalin requested a review from a team

March 13, 2023 18:13

chalin mentioned this pull request

Make build and CI more contributor friendly #2448

Closed

5 tasks

Member

tsloughter commented Mar 13, 2023

It isn't a failure under Windows (I'm on Fedora) but this does work and allows me to run npm serve successfully. Thanks!

svrnm approved these changes

View reviewed changes

tsloughter approved these changes

View reviewed changes

chalin merged commit e94c9d6 into open-telemetry:main

chalin deleted the chalin-im-warn-about-ext-url-2023-03-13 branch

March 13, 2023 18:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet