-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR-actions workflow with support for /fix:format
#2449
PR-actions workflow with support for /fix:format
#2449
Conversation
chalin
commented
Mar 3, 2023
- A first attempt at a comment-triggerable bot action to reformat files in a PR.
- Contributes to Make build and CI more contributor friendly #2448
Dunno if it'll trigger on this PR. Here goes ... Edit: it didn't trigger. Maybe it needs to be merged first? |
Hey @trask: what's the best way to test & debug new GH actions (that trigger on comments) like the one in this PR? |
push the PR to the btw, we have similar here: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/.github/workflows/comment-driven-automation.yml the problem which I don't have solution for yet is that when it pushes the commit back to the PR, it doesn't trigger workflow, and the only way to trigger workflow is to manually close and re-open the PR, e.g. open-telemetry/opentelemetry-java-instrumentation#7881 (comment) |
Oh, very cool that y'all have a script like that already. Thanks for guidance @trask, and the heads up regarding the (non-)triggering issue. |
24dbb57
to
7496c35
Compare
/fix:format
/fix:format
7496c35
to
fb52587
Compare
fb52587
to
2158a98
Compare
@cartermp @svrnm (cc @trask): this is ready for review. It's a first cut, but it's functional. I tested it from another repo. As mentioned in Commits made by this Action do not trigger new Workflow runs:
But we can always manually re-trigger the "Check format" action. Maybe we'll find a better solution down the line. |
Let's go with this for now and we can adjust if needed! |
@cartermp - FYI, I've tested the workflow and it goes through all the paces but the pushed commit doesn't make it back into the PR 🤷🏼♂️. I'll investigate as soon as I can, but it might not be until late next week. |
@cartermp - hey, it did work! Just took longer than I expected 🤷🏼♂️. |