Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document additional collector configuration syntax #1527

Merged

Conversation

evan-bradley
Copy link
Contributor

Document escaping $ using $$ and demonstrate that curly braces are
optional for environment variables.

Resolves open-telemetry/opentelemetry-collector#5614

Document escaping `$` using `$$` and demonstrate that curly braces are
optional for environment variables.

Resolves open-telemetry/opentelemetry-collector#5614
@evan-bradley evan-bradley requested a review from a team July 6, 2022 18:23
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 6, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: evan-bradley / name: Evan Bradley (c0f9dcf)

@cartermp
Copy link
Contributor

cartermp commented Jul 6, 2022

Thanks @evan-bradley - once the CLA is signed we can merge this.

@evan-bradley
Copy link
Contributor Author

Great, thanks. I've signed the CLA.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@chalin chalin merged commit 6526a2f into open-telemetry:main Jul 11, 2022
@evan-bradley evan-bradley deleted the document-collector-env-behavior branch July 15, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document $$ mechanism to escape env var expansion
3 participants