Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for telemetry section #1211

Merged
merged 3 commits into from
Mar 16, 2022

Conversation

TylerHelmuth
Copy link
Member

@TylerHelmuth TylerHelmuth commented Mar 15, 2022

Fixes #1181

This PR adds new documentation for the telemetry: section of the service: configuration. I tried to touch on the key configuration options, but also included links to all available options.


Preview: https://deploy-preview-1211--opentelemetry.netlify.app/docs/collector/configuration/

@TylerHelmuth TylerHelmuth requested a review from a team March 15, 2022 20:51
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps just make it explicit that the metrics can be scraped from localhost:8888/metrics?

@TylerHelmuth
Copy link
Member Author

Perhaps just make it explicit that the metrics can be scraped from localhost:8888/metrics?

Done.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all!

(I'll probably make a pass for copyedits separately.)

@chalin chalin merged commit cdf711f into open-telemetry:main Mar 16, 2022
@chalin chalin mentioned this pull request Mar 16, 2022
6 tasks
@TylerHelmuth TylerHelmuth deleted the issue-1181 branch March 16, 2022 15:44
@chalin chalin mentioned this pull request Apr 2, 2022
24 tasks
@chalin chalin mentioned this pull request Jul 5, 2022
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collector configuration doc is missing new service.telemetry subsection
4 participants