Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh go docs #1003

Merged
merged 3 commits into from
Dec 21, 2021
Merged

Refresh go docs #1003

merged 3 commits into from
Dec 21, 2021

Conversation

cartermp
Copy link
Contributor

@cartermp cartermp commented Dec 21, 2021

Pulling in the improvements made upstream

Preview: https://deploy-preview-1003--opentelemetry.netlify.app/

@cartermp cartermp requested a review from a team December 21, 2021 16:42
@cartermp
Copy link
Contributor Author

cartermp commented Dec 21, 2021

Argh, more upstream link changes need to be made, yay for my changes 🙃

I guess this can also go under "docs coming from upstream sources can make things harder"

@chalin
Copy link
Contributor

chalin commented Dec 21, 2021

Argh, more upstream link changes need to be made, yay for my changes 🙃

I guess this can also go under "docs coming from upstream sources can make things harder"

Yes, this is valuable feedback, ... which you might want to reiterate in #989?

@cartermp
Copy link
Contributor Author

@chalin this is ready now.

@chalin chalin merged commit 89dc64e into open-telemetry:main Dec 21, 2021
@chalin
Copy link
Contributor

chalin commented Dec 21, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants